RFR: 8262329: Fix JFR parser exception messages [v2]

Erik Gahlin egahlin at openjdk.java.net
Thu Feb 25 22:17:39 UTC 2021


On Thu, 25 Feb 2021 20:49:54 GMT, Jie Kang <jkang at openjdk.org> wrote:

> > > I'm not sure why there is a check for chunk header? I think the check can be removed, including the static field.
> > 
> > 
> > I am not sure either. From what I can glean from the log message, the intention is to print some information when a constant pool is never used, except for the ChunkHeader.
> 
> I think the intention is to log a pool that's never used. Wouldn't that make sense for the ChunkHeader checkpoint that was introduced with event streaming? Is it used elsewhere?

All recordings to disk are streaming, so it is emitted once every second, but the chunk header type is only inspected when downloading streaming data over JMX. Anyway, I think it should be treated as other pools and be included. 

This time, two wrongs made one right :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2714


More information about the hotspot-jfr-dev mailing list