RFR: 8256814: WeakProcessorPhases may be redundant [v2]

[Thomas Schatzl]

On Sat, 16 Jan 2021 15:40:31 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change which eliminates the WeakProcessorPhase class.
>> 
>> The OopStorageSet class is changed to provide scoped enums for the different
>> categories: StrongId, WeakId, and Id (for the union of strong and weak).
>> An accessor is provided for obtaining the storage corresponding to a
>> category value.
>> 
>> Various other enumerator ranges, array sizes and indices, and iterations are
>> derived directly from the corresponding OopStorageSet category's enum range.
>> 
>> Iteration over a category of enumerators can be done via EnumIterator.  The
>> iteration over storage objects makes use of that enum iteration, rather than
>> having a bespoke implementation.  Some use-cases need iteration of the
>> enumerators, with storage lookup from the enumerator; other use-cases just
>> need the storage objects.
>> 
>> Testing:
>> mach5 tier1-6
>> Local (linux-x64) hotspot:tier1 with -XX:+UseShenandoahGC
>
> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge branch 'master' into wpp4
>  - stefank review
>  - Remove WeakProcessorPhase, adding scoped enum categories to OopStorageSet.

Marked as reviewed by tschatzl (Reviewer).

src/hotspot/share/gc/shared/oopStorageSet.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.

It's 2021 by now, I suggest to update these before pushing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1862