RFR: 8256814: WeakProcessorPhases may be redundant

Kim Barrett kim.barrett at oracle.com
Mon Jan 18 10:41:38 UTC 2021


> On Jan 16, 2021, at 10:42 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Jan 12, 2021, at 5:12 AM, Stefan Karlsson <stefank at openjdk.java.net> wrote:
>> src/hotspot/share/gc/shared/weakProcessorTimes.hpp line 37:
>> 
>>> 35: class WeakProcessorTimes {
>>> 36: public:
>>> 37:   using StorageId = OopStorageSet::WeakId;
>> 
>> Could be private.
> 
> Here too I think public functions whose type signatures involve identifiers
> that can't be used by clients is problematic.  But I renamed it from
> StorageId to WeakId; looking at it again, the more generic name seems
> counterproductive here.

After thinking about this some more, I’m going to see what it looks like to just
eliminate the type alias entirely.



More information about the hotspot-jfr-dev mailing list