Integrated: 8259036: Failed JfrVersionSystem invariant when VM built with -fno-elide-constructors

Markus Grönlund mgronlun at openjdk.java.net
Tue Jan 19 15:30:40 UTC 2021


On Thu, 14 Jan 2021 17:16:16 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> Greetings,
> 
> please review this changeset to let JFR work in situations where the VM is built with -fno-elide-constructors.
> 
> The original means to interface with the JfrVersionSystem employed handles, but to work correctly, the handles relied on Return Value Optimization (RVO), which was a lazy assumption on my part.
> 
> The handles will now employ copy-and-swap for reference counting. 
> 
> Testing: jdk_jfr with (and without) build option -fno-elide-constructors
> 
> Thanks to Kim Barrett @kimbarrett for filing this issue.
> 
> Thank you
> Markus

This pull request has now been integrated.

Changeset: 5cfb36e7
Author:    Markus Grönlund <mgronlun at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/5cfb36e7
Stats:     215 lines in 5 files changed: 74 ins; 98 del; 43 mod

8259036: Failed JfrVersionSystem invariant when VM built with -fno-elide-constructors

Reviewed-by: egahlin

-------------

PR: https://git.openjdk.java.net/jdk/pull/2083


More information about the hotspot-jfr-dev mailing list