Integrated: 8256814: WeakProcessorPhases may be redundant

Kim Barrett kbarrett at openjdk.java.net
Fri Jan 22 13:17:08 UTC 2021


On Tue, 22 Dec 2020 04:59:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change which eliminates the WeakProcessorPhase class.
> 
> The OopStorageSet class is changed to provide scoped enums for the different
> categories: StrongId, WeakId, and Id (for the union of strong and weak).
> An accessor is provided for obtaining the storage corresponding to a
> category value.
> 
> Various other enumerator ranges, array sizes and indices, and iterations are
> derived directly from the corresponding OopStorageSet category's enum range.
> 
> Iteration over a category of enumerators can be done via EnumIterator.  The
> iteration over storage objects makes use of that enum iteration, rather than
> having a bespoke implementation.  Some use-cases need iteration of the
> enumerators, with storage lookup from the enumerator; other use-cases just
> need the storage objects.
> 
> Testing:
> mach5 tier1-6
> Local (linux-x64) hotspot:tier1 with -XX:+UseShenandoahGC

This pull request has now been integrated.

Changeset: 7ed8ba1c
Author:    Kim Barrett <kbarrett at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/7ed8ba1c
Stats:     1052 lines in 25 files changed: 398 ins; 465 del; 189 mod

8256814: WeakProcessorPhases may be redundant

Remove WeakProcessorPhase, adding scoped enum categories to OopStorageSet.

Reviewed-by: stefank, tschatzl, rkennke

-------------

PR: https://git.openjdk.java.net/jdk/pull/1862


More information about the hotspot-jfr-dev mailing list