[jdk16] RFR: 8257215: JFR: Events dropped when streaming over a chunk rotation [v2]

[Markus Grönlund]

On Fri, 29 Jan 2021 13:06:03 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi, 
>> 
>> Could I have review of an intermittent product issue. It happens about 1 out of 300 the test is run.
>> 
>> By design, chunk files that have been parsed are deleted. Problem is that the filename could be reused, which causes issues. This happens on the server, where the files are read before they are transfered over the network, and on the client when chunks are read from the local repository. 
>> 
>> The logic for creating the chunk file names is now in a separate class (ChunkFilename) so it can be shared by server and client. Another problem was the clock source being used when purging files. It was not always the same as when timestamp was taken from the chunk.
>> 
>> Testing: Ran TestRotate.java 2100 times without failure
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused code

Looks good.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/131