RFR: 8265271: JFR: Allow use of .jfc options when starting JFR [v3]

[Markus Grönlund]

On Thu, 10 Jun 2021 11:29:47 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review that makes it possible to specify event setting and .jfc options on command line (-XX:StartFlightRecoding) and jcmd (JFR.start). There are still a couple of issues to fix, so the correct information is returned for the DiagnosticMXBean, but plan is to add it soon and hopefully be able to check it in for JDK 17.
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused methods

Looks good!

src/hotspot/share/jfr/dcmd/jfrDcmds.cpp line 236:

> 234: 
> 235: void JfrDCmd::parse(CmdLine* line, char delim, TRAPS) {
> 236:     _args = line->args_addr();

Indentation.

src/hotspot/share/jfr/jni/jfrJavaSupport.cpp line 511:

> 509: }
> 510: 
> 511: // caller needs ResourceMark

Can remove this comment, since we added the optional c_heap parameter.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4414