[jdk17] RFR: 8268702: JFR diagnostic commands lack argument descriptors when viewed using Platform MBean Server

[Erik Gahlin]

On Tue, 15 Jun 2021 14:35:00 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> Greetings,
> 
> this changeset restores the diagnostic command argument descriptors that got lost as part of [JDK-8265271](https://bugs.openjdk.java.net/browse/JDK-8265271) .
> 
> Testing: jdk_jfr, manual verification
> 
> Thanks
> Markus

Marked as reviewed by egahlin (Reviewer).

src/hotspot/share/jfr/dcmd/jfrDcmds.cpp line 349:

> 347:   assert(arguments != NULL, "invariant");
> 348:   assert(arguments->is_array(), "must be array");
> 349:   GrowableArray<DCmdArgumentInfo*>* const array = new GrowableArray<DCmdArgumentInfo*>();

Maybe we could assert here, making sure num_arguments match the array length

-------------

PR: https://git.openjdk.java.net/jdk17/pull/57