RFR: 8261441: JFR: Filename expansion [v3]

[Jaroslav Bachorik]

On Tue, 22 Jun 2021 12:34:16 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi,
>> Could I have a review of this change that let the users could use `%p` in the filename to represent the PID  when JFR.start/stop/dump.
>> 
>> I haven't implemented `%t` described in the issue, because I don't think it's very useful.
>> 
>> Best,
>> Denghui Dong
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix format problem

src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdDump.java line 230:

> 228: 
> 229:                  filename        (Optional) Name of the file to which the flight recording data is
> 230:                                  dumped. The string '%%p' in the filename will be replaced with the

Should this be `%p` and not `%%p`?

src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStart.java line 335:

> 333: 
> 334:                  filename        (Optional) Name of the file to which the flight recording data is
> 335:                                  written when the recording is stopped. The string '%%p' in the

Should this be `%p` and not `%%p`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4550