RFR: 8261441: JFR: Filename expansion [v5]

Erik Gahlin egahlin at openjdk.java.net
Wed Jun 23 03:20:31 UTC 2021


On Wed, 23 Jun 2021 02:53:56 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi,
>> Could I have a review of this change that let the users could use `%p` in the filename to represent the PID  when JFR.start/stop/dump.
>> 
>> I haven't implemented `%t` described in the issue, because I don't think it's very useful.
>> 
>> Best,
>> Denghui Dong
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   null check

Why is not `%t` useful? 

If you start multiple processes, the same PID can be reused and cause a collision.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4550


More information about the hotspot-jfr-dev mailing list