RFR: 8261441: JFR: Filename expansion [v3]

Jaroslav Bachorik jbachorik at openjdk.java.net
Wed Jun 23 07:22:26 UTC 2021


On Tue, 22 Jun 2021 18:12:15 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdDump.java line 230:
>> 
>>> 228: 
>>> 229:                  filename        (Optional) Name of the file to which the flight recording data is
>>> 230:                                  dumped. The string '%%p' in the filename will be replaced with the
>> 
>> Should this be `%p` and not `%%p`?
>
> This method invokes String::formatted of this String, so we need '%%p' here.
> 
> https://github.com/openjdk/jdk/pull/4550/files/f3fed5ab7e00986cf685287f6654215145f6bb40#diff-48d2f4fec466ce18084c7fe1ad30c5a842f93ab85713efcf6c6108b0574383c5L272

��

>> src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdStart.java line 335:
>> 
>>> 333: 
>>> 334:                  filename        (Optional) Name of the file to which the flight recording data is
>>> 335:                                  written when the recording is stopped. The string '%%p' in the
>> 
>> Should this be `%p` and not `%%p`?
>
> same as above

��

-------------

PR: https://git.openjdk.java.net/jdk/pull/4550


More information about the hotspot-jfr-dev mailing list