RFR: 8269225: JFR.stop misses the written info when the filename is only specified by JFR.start [v2]

Denghui Dong ddong at openjdk.java.net
Thu Jun 24 01:47:01 UTC 2021


> Hi,
> 
> Could I have a review of this small fix?
> 
> JFR.stop misses the written info when the filename is only specified by JFR.start, for example:
> 
> $jcmd 87802 JFR.start name=test filename=2.jfr
> 87802:
> Started recording 1. No limit specified, using maxsize=250MB as default.
> 
> Use jcmd 87802 JFR.dump name=test to copy recording data to file.
> 
> $jcmd 87802 JFR.stop name=test
> 87802:
> Stopped recording "test".
> 
> 
> The 'JFR.stop' didn't print written info, but actually, 2.jfr was generated.

Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:

  test

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4573/files
  - new: https://git.openjdk.java.net/jdk/pull/4573/files/82b5e224..42c00a52

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4573&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4573&range=00-01

  Stats: 48 lines in 1 file changed: 48 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4573.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4573/head:pull/4573

PR: https://git.openjdk.java.net/jdk/pull/4573


More information about the hotspot-jfr-dev mailing list