RFR: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"

[Erik Gahlin]

On Thu, 24 Jun 2021 12:14:17 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> Greetings,
> 
> Please help review this small changeset to remove an invalid assertion; reasoning is summarized in the JIRA issue.
> 
> Testing: jdk_jfr
> 
> Thanks
> Markus

I'm OK with removing assert, given that it is unlikely to happen in production code, but I think we should try to fix it for JDK 18 (and possibly backport).

Starting up JFR is an expensive operation, in this case a second time, so It doesn't seem unreasonable to add some code to reset the state properly, even if it involves iterating all classes, introducing a safepoint or taking some lock.

-------------

Marked as reviewed by egahlin (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4583