RFR: 8265919: RunThese30M fails "assert((!(((((JfrTraceIdBits::load(value)) & ((1 << 4) << 8)) != 0))))) failed: invariant"

[Markus Grönlund]

On Thu, 24 Jun 2021 12:14:17 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> Greetings,
> 
> Please help review this small changeset to remove an invalid assertion; reasoning is summarized in the JIRA issue.
> 
> Testing: jdk_jfr
> 
> Thanks
> Markus

Right. For product builds, the return (just after the assert), would have caused the serialized state not to be reset, because the expectation was that no artifacts would not have such a state.  A non-cleared serialized state could cause the artifact to not be written to the constant pool correctly later, as it would be assumed to have been written already (has the serialized state bit set). The removal of the return lets the code fall-through for the serialized state bit(s) to be cleared explicitly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4583