RFR: 8258431: Provide a JFR event with live set size estimate
Jaroslav Bachorik
jbachorik at openjdk.java.net
Mon Mar 1 13:15:48 UTC 2021
On Mon, 22 Feb 2021 16:50:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 4578:
>>
>>> 4576:
>>> 4577: void G1CollectedHeap::set_live(size_t bytes) {
>>> 4578: Atomic::release_store(&_live_size, bytes);
>>
>> I don't think this requires `release_store`, regular `store` would be enough. G1 folks can say for sure.
>
> Not required.
>> src/hotspot/share/gc/shared/genCollectedHeap.hpp line 183:
>>
>>> 181: size_t live = _live_size;
>>> 182: return live > 0 ? live : used();
>>> 183: };
>>
>> I think the implementation belongs to `genCollectedHeap.cpp`.
>
> +1. Does not seem to be performance sensitive.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2579
More information about the hotspot-jfr-dev
mailing list