RFR: 8258414: OldObjectSample events too expensive [v2]

Markus Grönlund mgronlun at openjdk.java.net
Thu Mar 11 10:45:10 UTC 2021


On Wed, 10 Mar 2021 15:03:55 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   lookup_for_leak_profiler
>
> src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp line 223:
> 
>> 221: 
>> 222: // invariant is that the entry to be resolved actually exists in the table
>> 223: const JfrStackTrace* JfrStackTraceRepository::lookup(unsigned int hash, traceid id) {
> 
> Could the comment be extended to make it explicit that the lookup will be done only in the leak profiler stacktrace repo? Or, better yet the method renamed to `lookup_in_leak_profiler()` (but it might be too long ...).

Thanks, Jaroslav - yes, indeed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2780


More information about the hotspot-jfr-dev mailing list