Integrated: JDK-8263426: Reflow JfrNetworkUtilization::send_events

[Aleksey Shipilev]

On Thu, 11 Mar 2021 09:32:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> SonarCloud instance reports a problem in JfrNetworkUtilization::send_events: "Identical sub-expressions on both sides of operator "-"." here:
> 
>   const JfrTickspan interval = last_sample_instant == 0 ? cur_time - cur_time : cur_time - last_sample_instant;
> 
> Note `cur_time - cur_time`. It would seem that `interval` is effectively zero when `last_sample_instant` is not yet initialized. And I see that the subsequent code checks for `interval.value() > 0` for every interface. That can be optimized a bit: when `last_sample_instant` is not available, do not enter the loop, and don't check `interval.value()`.
> 
> Additional testing:
>  - [x] `jdk_jfr` on Linux x86_64

This pull request has now been integrated.

Changeset: ff259393
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ff259393
Stats:     6 lines in 1 file changed: 1 ins; 1 del; 4 mod

8263426: Reflow JfrNetworkUtilization::send_events

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.java.net/jdk/pull/2935