RFR: 8260862 JFR: New configure command for the jfr tool [v2]

Markus Grönlund mgronlun at openjdk.java.net
Thu Mar 25 18:14:26 UTC 2021


On Thu, 25 Mar 2021 17:36:21 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of a new configure command for the jfr tool. Purpose is to simplify changing event settings:
>> 
>> $ jfr configure method-profiling=high gc=detailed
>> Configuration written successfully to:
>> 
>> 
>> For more details, see CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8260863
>> 
>> Testing: 
>> - jdk/jdk/jfr
>> - JMC recording wizard
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Review feedback
>  - Fix copyright and formatting

Looks good Erik, nice work.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3100


More information about the hotspot-jfr-dev mailing list