RFR: 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect [v4]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Tue Nov 9 02:30:45 UTC 2021
On Tue, 26 Oct 2021 07:26:43 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Add dumppath to JFR.configure dcmd
>> - Add "\n" after printing exception
>> - Merge remote-tracking branch 'upstream/master' into JDK-8275375-2
>> - Propagate IOException at setDumpPath() to the caller
>> - Refactoring setDumpPath related code
>> - 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
>
> If I remember correctly, if the exception is cleared, the exit status of the process will be incorrect.
>
> That said, it would be good to get rid of "jdk.jfr.internal.dcmd.DCmdException: Could not ...", but it doesn't necessary need to be fixed in this PR and it must work with other options as well, for example JFR.configure <pid> samplethreads=incorrect
@egahlin Can you review this PR?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6000
More information about the hotspot-jfr-dev
mailing list