RFR: JDK-8275091 : /src/jdk.management.jfr/share/classes/module-info.java has non-canonical order

kabutz duke at openjdk.java.net
Tue Oct 12 07:52:00 UTC 2021


The canonical order of declarations inside the module-info.java file seems to follow the order:

`module some.module.name {
  requires ...
 
  requires transitive ...

  exports ... 

  exports ... to ... 

  opens ... to ...

  uses ...

  provides ... with ...
}
`

The "requires" was changed to "requires transitive" as part of a larger change [8248564](https://github.com/openjdk/jdk/commit/738efea9c6306308fbb134003796b2bdd3f888dd), but not reordered.

This is the only module-info.java file in the src/** directory that deviates from what appears to be the canonical order.

-------------

Commit messages:
 - Merge branch 'openjdk:master' into maintain_canonical_order_in_module-info.java
 - Maintain the canonical order in module-info.java

Changes: https://git.openjdk.java.net/jdk/pull/5738/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5738&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8275091
  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5738.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5738/head:pull/5738

PR: https://git.openjdk.java.net/jdk/pull/5738


More information about the hotspot-jfr-dev mailing list