RFR: 8271949: dumppath in -XX:FlightRecorderOptions does not affect [v6]

[Markus Grönlund]

On Wed, 13 Oct 2021 01:08:22 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> We set `dumppath` in `-XX:FlightRecorderOptions` or `JFR.configure dumppath` jcmd when we want to set emergency dump path. However they do not afffect.
>> 
>> ### -XX:FlightRecorderOptions
>> 
>> 
>> $ java -XX:FlightRecorderOptions=dumppath=`pwd` -XX:StartFlightRecording -Xlog:exceptions=info --version
>> [0.032s][info][exceptions] Exception <a 'java/lang/IllegalArgumentException'{0x00000007470163b8}: Unknown argument 'dumppath' in diagnostic command.> (0x00000007470163b8)
>> thrown [open/src/hotspot/share/services/diagnosticFramework.cpp, line 215]
>> for thread 0x00007f4f700236a0
>> [0.033s][error][arguments ] Unknown argument 'dumppath' in diagnostic command.
>> Error occurred during initialization of VM
>> Failure when starting JFR on_create_vm_2
>> 
>> 
>> ### jcmd
>> 
>> `jcmd` shows the configuration change was succeeded, but it would not affect.
>> 
>> 
>> $ jcmd 1046 JFR.configure dumppath=/tmp
>> 1046:
>> Dump path: /tmp
>
> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Use current directory if emergency dump fails on specified path
>  - Merge remote-tracking branch 'upstream/master' into JDK-8271949
>  - Print warning message instead of throwing exception if JFR will not write emergency dump
>  - Merge remote-tracking branch 'upstream/master' into JDK-8271949
>  - Set absolute path to JFR emergency dump path
>  - Check write permission on JFR emergency dump path in configuration
>  - Update testcase
>  - Merge remote-tracking branch 'upstream/master' into JDK-8271949
>  - Remove USER_HOME
>  - 8271949: dumppath in -XX:FlightRecorderOptions does not affect

This is now causing secondary crashes:

jvm!VMError::report+0xb7a [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 726] 
jvm!VMError::report_and_die+0x6ce [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 1652] 
jvm!VMError::report_and_die+0x81 [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 1437] 
jvm!report_vm_error+0x9d [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\debug.cpp @ 283] 
jvm!create_emergency_dump_path+0x2f [d:\dev\github\jdk_copy\open\src\hotspot\share\jfr\recorder\repository\jfrEmergencyDump.cpp @ 113] 
jvm!JfrEmergencyDump::open_emergency_dump_file+0x7b [d:\dev\github\jdk_copy\open\src\hotspot\share\jfr\recorder\repository\jfrEmergencyDump.cpp @ 146] 
jvm!JfrEmergencyDump::on_vm_error_report+0x57 [d:\dev\github\jdk_copy\open\src\hotspot\share\jfr\recorder\repository\jfrEmergencyDump.cpp @ 185] 
jvm!JfrRepository::on_vm_error_report+0x1c [d:\dev\github\jdk_copy\open\src\hotspot\share\jfr\recorder\repository\jfrRepository.cpp @ 94] 
jvm!Jfr::on_vm_error_report+0x1f [d:\dev\github\jdk_copy\open\src\hotspot\share\jfr\jfr.cpp @ 105] 
jvm!VMError::report+0xb7a [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 726] 
jvm!VMError::report_and_die+0x5b8 [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 1621] 
jvm!VMError::report_and_die+0x8d [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 1425] 
jvm!VMError::report_and_die+0x51 [d:\dev\github\jdk_copy\open\src\hotspot\share\utilities\vmError.cpp @ 1431] 
jvm!report_error+0x39 [d:\dev\github\jdk_copy\open\src\hotspot\os\windows\os_windows.cpp @ 2477] 
jvm!topLevelExceptionFilter+0x5a5 [d:\dev\github\jdk_copy\open\src\hotspot\os\windows\os_windows.cpp @ 2680] 
jvm!`thread_native_entry'::`1'::filt$0+0x22 [d:\dev\github\jdk_copy\open\src\hotspot\os\windows\os_windows.cpp @ 545] 
VCRUNTIME140!__C_specific_handler+0xa0 [d:\A01_work\12\s\src\vctools\crt\vcruntime\src\eh\riscchandler.cpp @ 389] 
ntdll!RtlpExecuteHandlerForException+0xf
ntdll!RtlDispatchException+0x40f
ntdll!KiUserExceptionDispatch+0x2e

-------------

PR: https://git.openjdk.java.net/jdk/pull/5019