RFR: 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect [v4]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Tue Oct 26 10:09:11 UTC 2021
On Tue, 26 Oct 2021 05:22:42 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> This PR is for redo-ing [JDK-8271949](https://bugs.openjdk.java.net/browse/JDK-8271949).
>> I changed to use `SecuritySupport` at `Options::setDumpPath` as @egahlin mentioned. Please see change both Options.java and SecuritySupport.java .
>>
>> I've tested this change with all jdk/jfr tests on Linux x64, and they works fine.
>> @egahlin @mgronlun Can you run Mach5 tests with this change?
>
> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Add dumppath to JFR.configure dcmd
> - Add "\n" after printing exception
> - Merge remote-tracking branch 'upstream/master' into JDK-8275375-2
> - Propagate IOException at setDumpPath() to the caller
> - Refactoring setDumpPath related code
> - 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
> but it doesn't necessary need to be fixed in this PR and it must work with other options as well, for example JFR.configure samplethreads=incorrect
Ok, I will not make more change around them, so can you review this PR?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6000
More information about the hotspot-jfr-dev
mailing list