RFR: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler [v2]

Aleksey Shipilev shade at openjdk.java.net
Fri Apr 8 11:27:41 UTC 2022


On Thu, 7 Apr 2022 18:48:24 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> BitSet::BitMapFragmentTable needs a destructor to cleanup its contents to avoid leaking hashtable entries.
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Thomas's comment

Looks fine, modulo a bit of indenting.

src/hotspot/share/jfr/leakprofiler/chains/bitset.cpp line 40:

> 38:         free_entry(tmp);
> 39:       }
> 40:     }

I think indenting is a bit off here: should be 2 spaces at all columns. Probably a copy-paste--from-destructor error.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8148


More information about the hotspot-jfr-dev mailing list