RFR: 8284532: Memory leak in BitSet::BitMapFragmentTable in JFR leak profiler [v3]

[Zhengyu Gu]

On Fri, 8 Apr 2022 03:42:39 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>>> Hi Zhengyu,
>>> 
>>> small remark inline, otherwise this looks okay. This should really be a utility function in BasicHashMap.
>> 
>> Probably, I would like to defer it to separate CR, which it may touch quite a few places.
>> 
>>> 
>>> What tests did you run?
>>> 
>> Manual test with JFR recording `path-to-gc-roots=true`, then run `jcmd  JFR.dump`
>> 
>>> Cheers, Thomas
>>> 
>>> Note that there is #7964 open too, but it may be easier to get this one in first to keep it easy to backport.
>
>> > Hi Zhengyu,
>> > small remark inline, otherwise this looks okay. This should really be a utility function in BasicHashMap.
>> 
>> Probably, I would like to defer it to separate CR, which it may touch quite a few places.
>> 
> 
> Sure. You just follow established patterns here.
> 
>> > What tests did you run?
>> 
>> Manual test with JFR recording `path-to-gc-roots=true`, then run `jcmd JFR.dump`
> 
> How did you notice the memory leak? In NMT dumps?

Thanks, @tstuefe @mgronlun @shipilev

-------------

PR: https://git.openjdk.java.net/jdk/pull/8148