RFR: 8284549: JFR: FieldTable leaks FieldInfoTable member [v2]

Zhengyu Gu zgu at openjdk.java.net
Sun Apr 10 00:04:30 UTC 2022


On Sat, 9 Apr 2022 06:54:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Thomas' comment
>
> src/hotspot/share/jfr/leakprofiler/checkpoint/objectSampleWriter.cpp line 626:
> 
>> 624: 
>> 625:   if (field_infos != NULL) {
>> 626:     field_infos->clear();
> 
> In other places, for in-place created objects, we just call the destructor manually, with a clarifying comment. I would find that a bit clearer.

Okay. Although I don't like to call destructor directly, but there are other instances.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8149


More information about the hotspot-jfr-dev mailing list