RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

Serguei Spitsyn sspitsyn at openjdk.java.net
Thu Apr 28 02:24:53 UTC 2022


On Wed, 27 Apr 2022 19:00:52 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2388:
> 
>> 2386: }
>> 2387: 
>> 2388: void
> 
> @sspitsyn We should clean up this aberrant style of putting the return type on the line before the rest of the function declaration after this integration.  It looks so strange.  I noticed that it's pre-existing for other functions in this file.

I'm okay to follow any style. We can do it after the integration.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8166


More information about the hotspot-jfr-dev mailing list