RFR: JDK-8297959: Provide better descriptions for some Operating System JFR events [v2]

Thomas Stuefe stuefe at openjdk.org
Mon Dec 5 08:35:39 UTC 2022


On Mon, 5 Dec 2022 08:24:33 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Some Operating System JFR events currently lack descriptions , this could be improved.
>> See for example https://sap.github.io/SapMachine/jfrevents/20.html#osinformation
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust description of OS Information

Small nits, otherwise good. If @egahlin is happy, I am too.

src/hotspot/share/jfr/metadata/metadata.xml line 736:

> 734: 
> 735:   <Event name="OSInformation" category="Operating System" label="OS Information"
> 736:          description="Description of the OS the JVM runs on, for example a uname-like output"

comma after example

src/hotspot/share/jfr/metadata/metadata.xml line 753:

> 751: 
> 752:   <Event name="InitialEnvironmentVariable" category="Operating System" label="Initial Environment Variable"
> 753:          description="Key and value pairs for environment variables at JVM startup"

Key-value pairs

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11478


More information about the hotspot-jfr-dev mailing list