RFR: 8292265: Add old gen used field at G1HeapSummary JFR event. [v2]
Albert Mingkun Yang
ayang at openjdk.org
Mon Dec 5 14:40:15 UTC 2022
On Mon, 28 Nov 2022 06:30:42 GMT, Sangheon Kim <sangheki at openjdk.org> wrote:
>> Hi all,
>>
>> Can I have reviews for this change which adds 'old gen used' field at existing G1HeapSummary event?
>>
>> Testing: tier1 ~ tier3
>>
>> Thanks,
>> Sangheon
>
> Sangheon Kim has updated the pull request incrementally with one additional commit since the last revision:
>
> Thomas review
src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2562:
> 2560: size_t eden_used_bytes = _monitoring_support->eden_space_used();
> 2561: size_t survivor_used_bytes = _monitoring_support->survivor_space_used();
> 2562: size_t old_used_bytes = _monitoring_support->old_gen_used();
I think it's best to include `gen` in the name (across the whole PR), just to avoid the confusion of Old-region-type vs old-generation.
-------------
PR: https://git.openjdk.org/jdk/pull/11303
More information about the hotspot-jfr-dev
mailing list