[jdk20] Integrated: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4

Erik Gahlin egahlin at openjdk.org
Wed Dec 14 13:44:21 UTC 2022


On Wed, 14 Dec 2022 09:40:28 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a follow up fix to [JDK-8298129](https://bugs.openjdk.org/browse/JDK-8298129) to allow check point events with a size larger than u4 to be transferred over JMX.
> 
> Testing: jdk/jdk/jfr 
> 
> An overflow happens at line 265 if v and payLoadSize is not long values:
> 
> payLoadSize += (v << sizeShift);
> 
> The field should be renamed to payloadSize, but I will do it separately to keep this change easy to review.
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: 0eeaf6b2
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.org/jdk20/commit/0eeaf6b219758563712d951b3c6ff160ebeff52d
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.org/jdk20/pull/30


More information about the hotspot-jfr-dev mailing list