RFR: 8279613: JFR: Snippify Javadoc [v3]

Markus Grönlund mgronlun at openjdk.java.net
Mon Feb 7 19:16:10 UTC 2022


On Mon, 7 Feb 2022 16:38:57 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review that uses the new snippet tag described in https://openjdk.java.net/jeps/413
>> 
>> I found a couple of issues with the current documentation, but to simplify review I kept the code samples as is. I will improve documentation separately. 
>> 
>> I added package "example1" and "example2"  to the Snippet file to avoid collisions and complaints about code not being in a package (at least when using Eclipse).
>> 
>> Testing: tier1 + jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update formatting

Marked as reviewed by mgronlun (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7157


More information about the hotspot-jfr-dev mailing list