RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. [v2]

KIRIYAMA Takuya duke at openjdk.java.net
Fri Feb 18 05:44:35 UTC 2022


On Thu, 17 Feb 2022 10:24:19 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
>
> src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp line 90:
> 
>> 88:         JfrJavaSupport::abort(JfrJavaSupport::new_string(msg, jt), jt, false);
>> 89:     }
>> 90:     else {
> 
> The else block can be removed. Just put the guarantee inline with the other code.

Thank you so much. You're right. I removed the else block.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7227


More information about the hotspot-jfr-dev mailing list