RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. [v4]
KIRIYAMA Takuya
duke at openjdk.java.net
Tue Feb 22 05:53:31 UTC 2022
> I think JFR should report an error message and jvm should shut down safely instead of gurantee failure.
>
> For instance, jdk.jfr.internal.Repository#newChunk() reports an appropriate message and stops jvm as below
> by using JfrJavaSupport::abort().
>
> [0.673s][error][jfr] Could not create chunk in repository /tmp/2022_01_12_22_32_42_18030, class java.io.IOException: Unable to create JFR repository directory using base location (/tmp)
> [0.673s][error][jfr,system] Could not create chunk in repository /tmp/2022_01_12_22_32_42_18030, class java.io.IOException: Unable to create JFR repository directory using base location (/tmp)
> [0.673s][error][jfr,system] An irrecoverable error in Jfr. Shutting down VM...
>
> I modified StreamWriterHost not to call guarantee failure but to call JfrJavaSupport::abort().
> I added a argument to JfrJavaSupport::abort() which tells os::abort() not to put out core
> because there is no space on device.
> Could you please review the fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7227/files
- new: https://git.openjdk.java.net/jdk/pull/7227/files/561cce33..a6958ad6
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7227&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7227&range=02-03
Stats: 20 lines in 3 files changed: 4 ins; 9 del; 7 mod
Patch: https://git.openjdk.java.net/jdk/pull/7227.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7227/head:pull/7227
PR: https://git.openjdk.java.net/jdk/pull/7227
More information about the hotspot-jfr-dev
mailing list