RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. [v3]

[KIRIYAMA Takuya]

On Fri, 18 Feb 2022 11:17:40 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
>
> src/hotspot/share/jfr/writers/jfrStreamWriterHost.inline.hpp line 88:
> 
>> 86:         JavaThread* jt = JavaThread::current();
>> 87:         ThreadInVMfromNative transition(jt);
>> 88:         JfrJavaSupport::abort(JfrJavaSupport::new_string(msg, jt), jt, false);
> 
> Hi again Takuya, I'm sorry, but I should have noticed this earlier:
> 
> I now see that the code needs to allocate a Java string oop to conform to the existing abort function signature, which caters to invocations from Java. Then abort() immediately strips out the c-string from the oop. To be correct, also headers for logging/log.hpp and runtime/thread.inline.hpp should need be included.
> 
> I believe we can simplify this by updating the abort() signature so that we don't need to drag in those extra dependencies. Please see my following comment where I suggest a way to do this.
> 
> Thanks for your patience
> Markus

Thank you for your valuable comments. I agree with you. I corrected this fix in accordance with your suggestions.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7227