RFR: 8271232: JFR: Scrub recording data [v3]

[Erik Gahlin]

On Tue, 22 Feb 2022 21:20:18 GMT, Gunnar Morling <duke at openjdk.java.net> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary assignment
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Scrub.java line 83:
> 
>> 81:         stream.println("  --include-threads <filter>      Select events matching a thread name");
>> 82:         stream.println();
>> 83:         stream.println("  --exclude-threads <filter>      Exclude events matching a thread name");
> 
> Did you consider to allow filtering based on timestamps? It would be useful if one could extract a specific interval, e.g. 30 sec. starting at a given timestamp) from a larger recording.

Yes, I also considered thresholds and random removal of events, but got lost in how the option syntax should look like. There is some precedence in JFR.dump that we might want to use, or not. In the end, I decided to keep the command line tool simple for now, all the filtering capabilities exists in the API. Most likely, I will revisit the tool later in the release to fix a few things. If time permits, I might look at time-based filtering as well then.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7548