Integrated: 8282153 JFR: Check for recording waste
Erik Gahlin
egahlin at openjdk.java.net
Sat Feb 26 09:00:00 UTC 2022
On Wed, 23 Feb 2022 09:47:33 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Hi,
>
> Could I have a review of test that looks for wasted space in recording files. Waste is typically constant pool data that is not referenced by an event. There have been issues with this in the past.
>
> I set an upper limit of 2% waste. It's typically around 0,7% in the test. Unused threads create waste and something we may want to prevent in the future. The fix relies on the method RecordingFile::write(Path, Predicate) being added. See "JDK-8271232: JFR: Scrub recording data"
>
> The test prints a histogram of the event types to make sure expected events are emitted.
>
> Testing: jdk/jdk/jfr/jvm/TestWaste.java 100 times
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: cf6d2565
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/cf6d2565e93ac13fd03f01a0624530d6750d02c3
Stats: 128 lines in 1 file changed: 128 ins; 0 del; 0 mod
8282153: JFR: Check for recording waste
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.java.net/jdk/pull/7586
More information about the hotspot-jfr-dev
mailing list