RFR: 8279797: JFR: Show .jfc options in JFR.start help

[Markus Grönlund]

On Fri, 14 Jan 2022 02:32:55 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> Could I have review of an enhancement that shows available .jfc options in the help text for JFR.start. I also fixed a typo. 
> 
> I choose to return an empty string if the default.jfc or profile.jfc can't be parsed. This could potentially happen if a user modifies files in JAVA_HOME/lib/jfr. An alternative would be to return an error message in the help text, but I think it would be hard for users to understand. Likely they think the text describes the command somehow. When they use JFR.start, they will get a parse failure, and it's much more easier to understand that point.
> 
> This PR has a conflict with https://github.com/openjdk/jdk/pull/7066, so "new JFCModel(s, l -> {});" might need to be changed to "JFCModel.create(s,  l -> {});" before checking in.
> 
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7073