RFR: 8279797: JFR: Show .jfc options in JFR.start help [v3]

[Erik Gahlin]

> Hi,
> 
> Could I have review of an enhancement that shows available .jfc options in the help text for JFR.start. I also fixed a typo. 
> 
> I choose to return an empty string if the default.jfc or profile.jfc can't be parsed. This could potentially happen if a user modifies files in JAVA_HOME/lib/jfr. An alternative would be to return an error message in the help text, but I think it would be hard for users to understand. Likely they think the text describes the command somehow. When they use JFR.start, they will get a parse failure, and it's much more easier to understand at that point.
> 
> This PR has a conflict with https://github.com/openjdk/jdk/pull/7066, so "new JFCModel(s, l -> {});" might need to be changed to "JFCModel.create(s,  l -> {});" before checking in.
> 
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:

  Use JFCModel.create

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7073/files
  - new: https://git.openjdk.java.net/jdk/pull/7073/files/8b088e7e..d2bcefb0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7073&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7073&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7073.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7073/head:pull/7073

PR: https://git.openjdk.java.net/jdk/pull/7073