RFR: 8279613: JFR: Snippify Javadoc [v2]

Erik Gahlin egahlin at openjdk.java.net
Fri Jan 21 03:03:33 UTC 2022


> Hi,
> 
> Could I have a review that uses the new snippet tag described in https://openjdk.java.net/jeps/413
> 
> I found a couple of issues with the current documentation, but to simplify review I kept the code samples as is. I will improve documentation separately. 
> 
> I added package "example1" and "example2"  to the Snippet file to avoid collisions and complaints about code not being in a package (at least when using Eclipse).
> 
> Testing: tier1 + jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:

  Missing copyright headers

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7157/files
  - new: https://git.openjdk.java.net/jdk/pull/7157/files/7942d3de..5dc159f0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7157&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7157&range=00-01

  Stats: 48 lines in 2 files changed: 48 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7157.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7157/head:pull/7157

PR: https://git.openjdk.java.net/jdk/pull/7157


More information about the hotspot-jfr-dev mailing list