RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v16]

[Tyler Steele]

On Sat, 29 Jan 2022 05:58:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Tyler Steele has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Changes macoss -> macosx in problem list
>>  - Refactors loadlib_aix: Removes redundant c++ class
>
> src/hotspot/os/aix/loadlib_aix.cpp line 116:
> 
>> 114: //   entry_t* next;
>> 115: //   loaded_module_t info;
>> 116: // };
> 
> please remove

Agreed. Thanks for catching this.

> src/hotspot/os/aix/os_perf_aix.cpp line 31:
> 
>> 29: #include "memory/resourceArea.hpp"
>> 30: #include "os_aix.inline.hpp"
>> 31: #include "precompiled.hpp"
> 
> precompiled.hpp must appear at the very top of the cpp file. The one exception from the "order includes alphabetically" rule. Oh, that, and people usually include system headers after hotspot ones.

�� 

Also, since I'm thinking of it here. I ran without precompiled.hpp as you mentioned elsewhere. No issues detected.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885