[jdk19] RFR: 8289183: jdk.jfr.consumer.RecordedThread.getId references Thread::getId, should be Thread::threadId [v2]
Erik Gahlin
egahlin at openjdk.org
Fri Jul 1 12:29:38 UTC 2022
> Could I have a review of PR that changes documentation from the now deprecated method Thread.getId() to the new Thread.threadId().
>
> I also fixed a typo, where it said "The Java thread". Should be "the OS thread".
>
> Testing: 'make docs' and inspect the result
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Add link to java.lang.Thread#threadId() in getJavaThreadId()
-------------
Changes:
- all: https://git.openjdk.org/jdk19/pull/93/files
- new: https://git.openjdk.org/jdk19/pull/93/files/3819c94e..49b33e60
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk19&pr=93&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk19&pr=93&range=00-01
Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk19/pull/93.diff
Fetch: git fetch https://git.openjdk.org/jdk19 pull/93/head:pull/93
PR: https://git.openjdk.org/jdk19/pull/93
More information about the hotspot-jfr-dev
mailing list