[jdk19] RFR: 8289183: jdk.jfr.consumer.RecordedThread.getId references Thread::getId, should be Thread::threadId [v3]
Alan Bateman
alanb at openjdk.org
Fri Jul 1 13:14:48 UTC 2022
On Fri, 1 Jul 2022 12:59:42 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Could I have a review of PR that changes documentation from the now deprecated method Thread.getId() to the new Thread.threadId().
>>
>> I also fixed a typo, where it said "The Java thread". Should be "the OS thread".
>>
>> Testing: 'make docs' and inspect the result
>>
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>
> Add link to getOSThreadId() to RecordedThread::getId()
This looks okay to me.
-------------
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.org/jdk19/pull/93
More information about the hotspot-jfr-dev
mailing list