RFR: 8282420: JFR: Remove event handlers [v6]
Erik Gahlin
egahlin at openjdk.org
Wed Jul 6 19:53:40 UTC 2022
On Wed, 6 Jul 2022 16:50:42 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor fixes
>
> src/hotspot/share/jfr/instrumentation/jfrResolution.hpp line 40:
>
>> 38: public:
>> 39: static void on_runtime_resolution(const CallInfo & info, TRAPS);
>> 40: static void on_c1_resolution(const GraphBuilder * builder, const ciKlass * holder, const ciMethod * target);
>
> Should the declarations of `on_c1_resolution` and `on_c2_resolution` be guarded with `COMPILER2_PRESENT` and `COMPILER1_PRESENT` since the method bodies are?
Yes. It's been fixed. See:
https://github.com/openjdk/jdk/pull/8680
-------------
PR: https://git.openjdk.org/jdk/pull/8383
More information about the hotspot-jfr-dev
mailing list