[jdk19] RFR: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration [v2]

Markus Grönlund mgronlun at openjdk.org
Thu Jul 7 13:05:55 UTC 2022


On Thu, 7 Jul 2022 12:17:50 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> Thank, looks good.

Thank you @robehn for reviewing!

> src/hotspot/share/jfr/recorder/storage/jfrStorageUtils.inline.hpp line 96:
> 
>> 94: static void retired_sensitive_acquire(Type* t, Thread* thread) {
>> 95:   assert(t != NULL, "invariant");
>> 96:   assert(thread != nullptr, "invariant");
> 
> Maybe add assertion that thread is current.

Thanks, added.

-------------

PR: https://git.openjdk.org/jdk19/pull/109


More information about the hotspot-jfr-dev mailing list