RFR: JDK-8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong

Thomas Schatzl tschatzl at openjdk.org
Mon Jul 11 12:41:51 UTC 2022


On Mon, 11 Jul 2022 12:25:10 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> src/hotspot/share/jfr/metadata/metadata.xml line 416:
>> 
>>> 414:     <Field type="ulong" contentType="bytes" name="undoWaste" label="Undo Wasted" description="Total memory wasted due to allocation undo within PLABs" />
>>> 415:     <Field type="ulong" contentType="bytes" name="regionEndWaste" label="Region End Wasted" description="Total memory wasted at the end of regions due to refill" />
>>> 416:     <Field type="uint" name="regionsRefilled" label="Region Refills" description="Number of regions refilled" />
>> 
>> Thanks for noticing. Maybe keep a `contentType="count"` though?
>
> I've changed the metadata analog to the numberOfRegions field of the G1HeapSummary event, which doesn't provide a content type. I can not find a count-like value which has a content type at all.

Probably I misread something. Looks good.

-------------

PR: https://git.openjdk.org/jdk/pull/9448


More information about the hotspot-jfr-dev mailing list