RFR: JDK-8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false" [v2]

Lutz Schmidt lucy at openjdk.org
Thu Jul 28 09:51:39 UTC 2022


On Wed, 27 Jul 2022 13:13:25 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> In seldom cases the TestJitRestart.java JFR test failed because no Jitrestart event was seen in the test.
>> Dean Long suggested to change the test a bit "How about changing the test to look at CodeCacheFull, compilation, and JitRestart events. It can test that no compilation events happen after CodeCacheFull unless a JitRestart comes first. So it would be testing the order of events and not absolute counts."
>> 
>> So I adjusted the test (still succeeds after a JitRestart is seen, but in case it is not seen only fails in case of Compilation events after CodeCacheFull).
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   sort events using StartTime

Changes look good to me.

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9612


More information about the hotspot-jfr-dev mailing list