Integrated: 8268398: 15% increase in JFR footprint in Noop-Base

[Erik Gahlin]

On Thu, 16 Jun 2022 21:41:44 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> Could I have a review of a PR that skips bytecode instrumentation for container events and initialisation of Container.metrics() if the JVM isn't running in a container, or to be precise, if container support is not available. If a user specifies -XX:-UseContainerSupport, events are not emitted. This was the case before this PR, and maybe it should be fixed, but it's an enhancement and outside the scope of this bug.
> 
> Testing:
> - jdk/jdk/jfr
> - Manual testing in a container.
> 
> I tried to run test/hotspot/jtreg/containers/docker/TestJFREvents.java, but the test is broken (image can't be built, so test is skipped). 
> 
> This fix may not be sufficient to reduce footprint introduced by the container events, but [JDK-8282420: JFR: Remove event handlers](https://bugs.openjdk.org/browse/JDK-8282420) also reduced number of loaded classes which should reduce footprint in JDK 19. There are an ongoing enhancement work to generate bytecode and metadata at build time, which will help, but it will be integrated in JDK 20. 
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: 97544be5
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.org/jdk19/commit/97544be5b68860bad0431ec88737ad7cdc284862
Stats:     56 lines in 8 files changed: 41 ins; 5 del; 10 mod

8268398: 15% increase in JFR footprint in Noop-Base

Reviewed-by: jbachorik

-------------

PR: https://git.openjdk.org/jdk19/pull/31