[jdk19] RFR: 8289183: jdk.jfr.consumer.RecordedThread.getId references Thread::getId, should be Thread::threadId

Alan Bateman alanb at openjdk.org
Thu Jun 30 06:11:40 UTC 2022


On Wed, 29 Jun 2022 20:57:30 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of PR  that changes documentation from the now deprecated method Thread.getId() to the new Thread.threadId().
> 
> I also fixed a typo, where it said "The Java thread". Should be "the OS thread".
> 
> Testing:  'make docs' and inspect the result
> 
> Thanks
> Erik

Marked as reviewed by alanb (Reviewer).

src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedThread.java line 100:

> 98:      * <p>
> 99:      * See {@link #getJavaThreadId()} for the ID that is returned by
> 100:      * {@code java.lang.Thread.threadId()}

Looks okay but maybe it should be a link?

-------------

PR: https://git.openjdk.org/jdk19/pull/93


More information about the hotspot-jfr-dev mailing list