RFR: 8284686: Interval of < 1 ms disables ExecutionSample events [v6]
Erik Gahlin
egahlin at openjdk.java.net
Fri May 6 13:00:37 UTC 2022
On Thu, 5 May 2022 14:04:15 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> I could, but lets ask @egahlin for his opinion. He proposed it in the first place.
>
> I think it's better to use the timeout provided by jtreg than hardwiring in a number in the test.
>
> The test could be run on different hardware or in modes that are very slow. It's better to allow the framework to provide the timeout. The test should not fail, so it shouldn't be an issue.
>
> I think the code looks fine, but could you remove the update to the documentation / specification. Also, perhaps add a comment in the test that the execution event requires a separate thread because the thread streaming events gets excluded from JFR (to avoid recursion).
>
> I will take it for a spin a few hundred times on different platforms to see if there are any intermittent issues.
I ran the test about 200 times on Windows, Linux and Mac and it seems fine.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8183
More information about the hotspot-jfr-dev
mailing list