RFR: 8286480: Remove the c1 getEventWriter() intrinsic to simplify post-Loom integration platform-porting efforts [v2]

Aleksey Shipilev shade at openjdk.java.net
Tue May 10 15:02:29 UTC 2022


On Tue, 10 May 2022 14:59:38 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> The C1 intrinsic for getEventWriter() did not materialize and is currently only bouncing a platform-specific stub to enter the VM, putting an unnecessary burden on post-Loom integration platform-porting efforts.
>> 
>> The platform-specific stub for C2, jfr_write_checkpoint, is still needed but is only called if a java/lang/VirtualThread is mounted. As such, it could be left unimplemented.
>> 
>> Testing: jdk_jfr
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - missing comma
>  - riscv

Changes requested by shade (Reviewer).

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3770:

> 3768:     address the_pc = __ pc();
> 3769:     jfr_prologue(the_pc, _masm, xthread);
> 3770:     __ call_VM_leaf(CAST_FROM_FN_PTR(address, JfrIntrinsicSupport::write_checkpoint) 1);

Spot the missing comma. ;)

-------------

PR: https://git.openjdk.java.net/jdk/pull/8631


More information about the hotspot-jfr-dev mailing list