Integrated: 8282420: JFR: Remove event handlers
Erik Gahlin
egahlin at openjdk.java.net
Tue May 10 16:17:44 UTC 2022
On Mon, 25 Apr 2022 16:49:42 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Hi,
>
> Could I have a review of a fix that removes event handler classes for JFR. Bytecode for event instrumentation is now only added to the event class. Benefits are:
>
> - No class memory leak in the boot class loader.
> - Reduce overhead from class loading during startup, which is important with additional JDK events that are coming (VirtualThreadStart etc.)
> - One less frame to traverse when recording a Java stack trace.
>
> Future benefits are:
>
> - Simplify creating instrumentation as a build step. See https://bugs.openjdk.java.net/browse/JDK-8279354
> - Simplify implementation of Event Metrics. See https://bugs.openjdk.java.net/browse/JDK-8224749
>
> When the Security Manager is removed, much of the code being added for security reasons can be deleted.
>
> There are few JFR hooks when code is being linked. Plan is to also use these for other events later.
>
> Testing: tier 1-4, jdk/jdk/jfr
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 0f377363
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/0f3773635d3f20866472b505ac390bac10ed4676
Stats: 4083 lines in 82 files changed: 2420 ins; 1050 del; 613 mod
8282420: JFR: Remove event handlers
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.java.net/jdk/pull/8383
More information about the hotspot-jfr-dev
mailing list